Added doctrings for generic_graph_view #6697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the docstring although the function is mainly used by the base classes.
This reverts commit 9b7f1ad.
just removed a whitespace that caused a style checking error.
dschult
reviewed
May 21, 2023
Co-authored-by: Dan Schult <dschult@colgate.edu>
Co-authored-by: Dan Schult <dschult@colgate.edu>
dschult
approved these changes
May 23, 2023
There was a problem hiding this comment.
This looks good to me.
I'll ask you to wrap the text in the doc_string so it is less than 88 chars on a line. (less is even better like <80 but the allow code to reach 88 chars so doc_strings can do that too.)
But this is a very minor thing so will approve it even without that.
Co-authored-by: Dan Schult <dschult@colgate.edu>
|
Thanks! I will respect the 80 cols next time. |
Alex-Markham
pushed a commit
to Alex-Markham/networkx
that referenced
this pull request
Oct 13, 2023
* Added doctrings for generic_graph_view Added the docstring although the function is mainly used by the base classes. * Revert "Added doctrings for generic_graph_view" This reverts commit 9b7f1ad. * Fixed lint issue just removed a whitespace that caused a style checking error. * Reformulation Co-authored-by: Dan Schult <dschult@colgate.edu> * Reformulation Co-authored-by: Dan Schult <dschult@colgate.edu> * Added more examples * Reformulation * Update networkx/classes/graphviews.py Co-authored-by: Dan Schult <dschult@colgate.edu> --------- Co-authored-by: Dan Schult <dschult@colgate.edu> Co-authored-by: Mridul Seth <mail@mriduls.com>
dschult
added a commit
to BrunoBaldissera/networkx
that referenced
this pull request
Oct 23, 2023
* Added doctrings for generic_graph_view Added the docstring although the function is mainly used by the base classes. * Revert "Added doctrings for generic_graph_view" This reverts commit 9b7f1ad. * Fixed lint issue just removed a whitespace that caused a style checking error. * Reformulation Co-authored-by: Dan Schult <dschult@colgate.edu> * Reformulation Co-authored-by: Dan Schult <dschult@colgate.edu> * Added more examples * Reformulation * Update networkx/classes/graphviews.py Co-authored-by: Dan Schult <dschult@colgate.edu> --------- Co-authored-by: Dan Schult <dschult@colgate.edu> Co-authored-by: Mridul Seth <mail@mriduls.com>
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
* Added doctrings for generic_graph_view Added the docstring although the function is mainly used by the base classes. * Revert "Added doctrings for generic_graph_view" This reverts commit 9b7f1ad. * Fixed lint issue just removed a whitespace that caused a style checking error. * Reformulation Co-authored-by: Dan Schult <dschult@colgate.edu> * Reformulation Co-authored-by: Dan Schult <dschult@colgate.edu> * Added more examples * Reformulation * Update networkx/classes/graphviews.py Co-authored-by: Dan Schult <dschult@colgate.edu> --------- Co-authored-by: Dan Schult <dschult@colgate.edu> Co-authored-by: Mridul Seth <mail@mriduls.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the docstring although the function is mainly used by the base classes.