Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Explicitly check for None/False in edge_attr during import from np #6825

Merged
merged 3 commits into from Oct 23, 2023
Merged

fix: Explicitly check for None/False in edge_attr during import from np #6825

merged 3 commits into from Oct 23, 2023

Conversation

j6k4m8
Copy link
Contributor

@j6k4m8 j6k4m8 commented Aug 1, 2023

@j6k4m8
Copy link
Contributor Author

j6k4m8 commented Oct 11, 2023

Not sure what's going on with black formatting here... Looks like running black is making no detectable changes..?

dschult
dschult approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@dschult dschult left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks!

(The black formatting was just removing a space at the end of two different lines. Invisible, but removed anyway.)

@MridulS MridulS merged commit 746371a into networkx:main Oct 23, 2023
38 checks passed
@jarrodmillman jarrodmillman added this to the 3.3 milestone Oct 23, 2023
dschult pushed a commit to BrunoBaldissera/networkx that referenced this pull request Oct 23, 2023
@j6k4m8 @dschult
fix: Explicitly check for None/False in edge_attr during import from …
a8a7231 
…np (networkx#6825)

* fix: Explicitly check for None/False in edge_attr during import from numpy

* lint: Fix convert_matrix.py

* formatting: Fix convert_matrix with black
Alex-Markham pushed a commit to Alex-Markham/networkx that referenced this pull request Oct 26, 2023
@j6k4m8
fix: Explicitly check for None/False in edge_attr during import from …
fc290ef 
…np (networkx#6825)

* fix: Explicitly check for None/False in edge_attr during import from numpy

* lint: Fix convert_matrix.py

* formatting: Fix convert_matrix with black
@jarrodmillman jarrodmillman mentioned this pull request Oct 27, 2023
Closed
jarrodmillman pushed a commit that referenced this pull request Oct 27, 2023
@j6k4m8 @jarrodmillman
fix: Explicitly check for None/False in edge_attr during import from …
22c04ac 
…np (#6825)

* fix: Explicitly check for None/False in edge_attr during import from numpy

* lint: Fix convert_matrix.py

* formatting: Fix convert_matrix with black
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
@j6k4m8 @cvanelteren
fix: Explicitly check for None/False in edge_attr during import from …
7df40b1 
…np (networkx#6825)

* fix: Explicitly check for None/False in edge_attr during import from numpy

* lint: Fix convert_matrix.py

* formatting: Fix convert_matrix with black
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschult dschult dschult approved these changes

Assignees
No one assigned
Labels
type: Maintenance
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@j6k4m8 @dschult @jarrodmillman @MridulS