Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Point the PR template to pre-commit #6902

Merged
merged 4 commits into from Sep 5, 2023

Conversation

MridulS
Copy link
Member

@MridulS MridulS commented Sep 5, 2023

The PR template was asking users to install black and use it manually to fix linting. We should be asking contributors to run pre-commit.

Co-authored-by: Dan Schult <dschult@colgate.edu>
@dschult
Copy link
Member

dschult commented Sep 5, 2023

I left an extra space in my suggestion. fixed now (maybe :)

@MridulS MridulS merged commit dee3e4e into networkx:main Sep 5, 2023
37 checks passed
@jarrodmillman jarrodmillman added this to the 3.2 milestone Sep 5, 2023
Alex-Markham pushed a commit to Alex-Markham/networkx that referenced this pull request Oct 13, 2023
* MAINT: Point the PR template to pre-commit

* you can't assign labels if you don't have the right permissions

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Dan Schult <dschult@colgate.edu>

* Update .github/PULL_REQUEST_TEMPLATE.md

---------

Co-authored-by: Dan Schult <dschult@colgate.edu>
dschult added a commit to BrunoBaldissera/networkx that referenced this pull request Oct 23, 2023
* MAINT: Point the PR template to pre-commit

* you can't assign labels if you don't have the right permissions

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Dan Schult <dschult@colgate.edu>

* Update .github/PULL_REQUEST_TEMPLATE.md

---------

Co-authored-by: Dan Schult <dschult@colgate.edu>
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
* MAINT: Point the PR template to pre-commit

* you can't assign labels if you don't have the right permissions

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Dan Schult <dschult@colgate.edu>

* Update .github/PULL_REQUEST_TEMPLATE.md

---------

Co-authored-by: Dan Schult <dschult@colgate.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants