Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare graphs for generator functions when running tests with backend #7066

Merged
merged 8 commits into from
Dec 7, 2023

Commits on Oct 26, 2023

  1. Compare graphs for generator functions when running tests with backend

    This is an alternative to networkx#7063.
    
    The backend testing infrastructure can call backend graph generator functions
    such as `circular_ladder_graph`, and it converts the backend Graph to a networkx
    Graph. This is a great way to test backend generators! However, sometimes iteration
    order is different when using the converted backend graph. So, our solution here
    is to *also* call the original networkx function when the return type is a Graph,
    compare results, then use the result from networkx to allow tests to pass.
    We use a series of assertions to help backend implementers identify differences.
    eriknw committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    853c4dc View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Configuration menu
    Copy the full SHA
    4da16f2 View commit details
    Browse the repository at this point in the history
  2. Add comment

    eriknw committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    80a85be View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Configuration menu
    Copy the full SHA
    b94eb0e View commit details
    Browse the repository at this point in the history
  2. Don't skip for star_graph

    eriknw committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    8e64ba5 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Move @nodes_or_number after @nx._dispatch

    If backends want to leverage `nodes_or_number`, they'll need to use it themselves.
    eriknw committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    7c38808 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Configuration menu
    Copy the full SHA
    2bdb436 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ebe2dc5 View commit details
    Browse the repository at this point in the history