-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare graphs for generator functions when running tests with backend #7066
Merged
Commits on Oct 26, 2023
-
Compare graphs for generator functions when running tests with backend
This is an alternative to networkx#7063. The backend testing infrastructure can call backend graph generator functions such as `circular_ladder_graph`, and it converts the backend Graph to a networkx Graph. This is a great way to test backend generators! However, sometimes iteration order is different when using the converted backend graph. So, our solution here is to *also* call the original networkx function when the return type is a Graph, compare results, then use the result from networkx to allow tests to pass. We use a series of assertions to help backend implementers identify differences.
Configuration menu - View commit details
-
Copy full SHA for 853c4dc - Browse repository at this point
Copy the full SHA 853c4dcView commit details
Commits on Oct 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4da16f2 - Browse repository at this point
Copy the full SHA 4da16f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80a85be - Browse repository at this point
Copy the full SHA 80a85beView commit details
Commits on Nov 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b94eb0e - Browse repository at this point
Copy the full SHA b94eb0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e64ba5 - Browse repository at this point
Copy the full SHA 8e64ba5View commit details
Commits on Nov 9, 2023
-
Move
@nodes_or_number
after@nx._dispatch
If backends want to leverage `nodes_or_number`, they'll need to use it themselves.
Configuration menu - View commit details
-
Copy full SHA for 7c38808 - Browse repository at this point
Copy the full SHA 7c38808View commit details
Commits on Nov 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2bdb436 - Browse repository at this point
Copy the full SHA 2bdb436View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebe2dc5 - Browse repository at this point
Copy the full SHA ebe2dc5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.