DEP : adding not_implemented_for("multigraph”) to k_core, k_shell, k_crust and k_corona
#7121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MridulS
approved these changes
Nov 29, 2023
dschult
approved these changes
Nov 30, 2023
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
…l`, `k_crust` and `k_corona` (networkx#7121) * DEP 4 k_ functions * added a few more tests * bug : replaced nx.is_multigraph(G) with G.is_multigraph()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the first commit, I have deprecated the behavior of the above four
k_functions to not take aMultiGraphobject as an argument.The above four functions are not defined for a multigraph so it would be appropriate to add a
not_implemented_for("multigraph”)decorator and strictly not allow aMultiGraphobject to avoid any confusion about multigraph andMultiGraphclass.Also, when the
core_numberdictionary is not passed as an argument in these functions and aMultiGraphobject is passed, then aNetworkXNotImplementedexception is raised. But, when thecore_numberdictionary is given then the sameMultiGraphgraph won't raise any exceptions. So, to avoid this kind of inconsistent behavior we should add the decorator.In the second commit, I have just added some more tests for the other functions in
core.py.origin : #7027
Thank you :)