Remove "networkx.plugins" and "networkx.plugin_info" entry-points
#7192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `"networkx.backends"` and `"networkx.backend_info"` instead. Version 3.2 supported both options. The next release can drop "plugin".
dschult
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
Thanks for this @eriknw
How long did we want both options to work? Is one release cycle enough? (probably -- we don't have many backends that we know of at this point). In the long run we should try to follow the NX deprecation cycle I guess. But I think this is fine!?!
|
Yeah, I think we're allowed to move faster b/c we call this "experimental". Once it's no longer experimental (in 2024?), we should probably follow standard deprecation cycle. Also, it's already extra nice that 3.2 supports both. |
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
…networkx#7192) Use `"networkx.backends"` and `"networkx.backend_info"` instead. Version 3.2 supported both options. The next release can drop "plugin".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
"networkx.backends"and"networkx.backend_info"instead. Version 3.2 supports both options. The next release can drop "plugin".I forgot to do this in #7157, which made a similar change.