Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc Improvements for Approximations Files #7338

Merged
merged 1 commit into from Mar 10, 2024
Merged

Doc Improvements for Approximations Files #7338

merged 1 commit into from Mar 10, 2024

Conversation

vanshika230
Copy link
Contributor

I have added the following things :-

  1. Added raises to - clustering_coefficients.py, dominating_sets.py, maxcut.py functions
  2. Added examples to distance _measures.py, dominating_sets.py, maxcut.py functions
    I would like a review on this and do any changes required.

mjschwenne
mjschwenne approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@mjschwenne mjschwenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dschult
dschult approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@dschult dschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dschult dschult merged commit 7a62ecb into networkx:main Mar 10, 2024
44 of 45 checks passed
@jarrodmillman jarrodmillman added this to the 3.3 milestone Mar 10, 2024
@vanshika230 vanshika230 deleted the doc_improvement_approx branch March 10, 2024 10:40
cvanelteren pushed a commit to cvanelteren/networkx that referenced this pull request Apr 22, 2024
@vanshika230 @cvanelteren
Doc Improvements for Approximations Files (networkx#7338)
7935720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschult dschult dschult approved these changes

@mjschwenne mjschwenne mjschwenne approved these changes

Assignees
No one assigned
Labels
Needs review type: Documentation
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vanshika230 @dschult @mjschwenne @jarrodmillman