Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "sci" calls that break embedding in wx. Switch from pylab to pyplot #747

Merged
merged 1 commit into from Oct 17, 2012

Conversation

hagberg
Copy link
Member

@hagberg hagberg commented Aug 5, 2012

Switch to using pyplot interface instead of pyplot.
Remove pylab.sci() calls that break embedding in gui canvases. I couldn't figure out why pylab.sci() was needed and I think it is safe to remove them.

@bjedwards
Copy link
Member

After reading what I could find in the docs onpylab.sci(), I am still unsure exactly what it does, but in the uses I've seen don't seem to relate to ours. Are we sure this isn't going to introduce some odd subtle bug down the road?

@hagberg
Copy link
Member Author

hagberg commented Aug 5, 2012

On Sun, Aug 5, 2012 at 12:08 PM, Ben Edwards
reply@reply.github.com
wrote:

After reading what I could find in the docs onpylab.sci(), I am still unsure exactly what it does, but in the uses I've seen don't seem to relate to ours. Are we sure this isn't going to introduce some odd subtle bug down the road?

It might cause some issues, but I couldn't find any in my testing. I
ran the networkx drawing examples and they worked fine. It might be
that when using colormaps for both edges and nodes this has an effect
(which is the active colormap).

In the long run this code needs to be substantially reworked.

@ghost ghost assigned hagberg Aug 5, 2012
loicseguin added a commit that referenced this pull request Aug 6, 2012
hagberg added a commit that referenced this pull request Oct 17, 2012
Remove "sci" calls that break embedding in wx. Switch from pylab to pyplot
@hagberg hagberg merged commit 8318f85 into networkx:master Oct 17, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants