Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #928 #929

Merged
merged 2 commits into from
Aug 13, 2013
Merged

Fixes #928 #929

merged 2 commits into from
Aug 13, 2013

Conversation

brycethomas
Copy link
Contributor

The existing implementation of .gexf serialization/deserialization exhibited several issues with reading and writing the graph's mode attribute, leading to dynamic graphs always being interpreted as static graphs. This fix addresses these issues. I have removed the mode parameter that was being passed to GEXFWriter's constructor as the mode seems like an attribute that should be stored on the graph itself (which it now is) and write_gexf was not passing through a value for mode to the constructor anyway.

There were several cases where data attributes pertaining to the mode of the graph were being defined but not used, which I've replaced with instance variables.

@hagberg
Copy link
Member

hagberg commented Aug 11, 2013

Looks good, just need to fix the failing test.

@brycethomas
Copy link
Contributor Author

The fixes in the new commit (c74fef6) correct a small issue with the mode dictionary key not existing when the graph is constructed in networkx rather than read in from a .gexf file. I have also changed one of the previously failing unit tests slightly to accommodate the mode attributes existence in the graph dictionary.

@ghost ghost assigned hagberg Aug 13, 2013
hagberg added a commit that referenced this pull request Aug 13, 2013
@hagberg hagberg merged commit 3a9695c into networkx:master Aug 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants