Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation of
.gexf
serialization/deserialization exhibited several issues with reading and writing the graph'smode
attribute, leading to dynamic graphs always being interpreted as static graphs. This fix addresses these issues. I have removed themode
parameter that was being passed toGEXFWriter
's constructor as the mode seems like an attribute that should be stored on the graph itself (which it now is) andwrite_gexf
was not passing through a value formode
to the constructor anyway.There were several cases where data attributes pertaining to the mode of the graph were being defined but not used, which I've replaced with instance variables.