-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook on Lowest Common Ancestor #69
Conversation
Hello @MridulS , I am continuously getting the following error: make: *** [Makefile:20: html] Error 1 Do you have any idea about what could be the reason? |
@dtekinoglu You need to include the content in |
Thank you! @inomag |
Hi @dtekinoglu, I am not sure what is wrong here but I think you can make the following changes -
|
@dtekinoglu Hmm there are some weird markdown cells here.
and then push it here? Thanks! |
Thank you @MridulS it passes the checks now 😄 I initally included a quiz cell which requires user input, but I thought that it is not supported. Thus, I removed that part. Am I correct? Do you suggest me to add it back? |
Yeah we are not that fancy just yet! For now let's just keep narrative notebooks for our users :) |
You can check the doc build here https://output.circle-artifacts.com/output/job/427d7bcf-0a12-412e-af58-618e4985f1e2/artifacts/0/site/_build/html/content/algorithms/lca/LCA.html Please do checkout the suggestions by @inomag, they should help with cleaning up the output :) |
@MridulS how can I apply lint pre-commit changes for the notebooks? |
@dtekinoglu I pushed the changes required to make the linters happy. It needs to run the pre-commit linters on the jupyter notebook (.ipynb) before converting it to myst.
After this you should see the changes the linters made inside the markdown myst files. I know this isn't an ideal workflow but currently |
content/algorithms/lca/LCA.md
Outdated
```{code-cell} | ||
import matplotlib.pyplot as plt | ||
import networkx as nx | ||
from networkx.drawing.nx_pydot import graphviz_layout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick note: Could you use from networkx.drawing.nx_agraph import graphviz_layout
instead of nx_pydot
? We would like to deprecate pydot
:)
@dtekinoglu well finally did the review :) I'll go ahead and merge this. Thanks for your contributions :) |
No description provided.