Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Switching to setuptools #69

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Schefflera-Arboricola
Copy link
Member

@Schefflera-Arboricola Schefflera-Arboricola commented Jun 8, 2024

origin PR #67 (Now, PR#67 is for adding additional linting settings in the future)

This PR switches the nx-parallel's building tool from hatchling to setuptools as it is more widely used and it's better for bigger projects and we need to explicitly mention all the packages(unlike hatchling) so that ensures that all packages are being built.

pre-file-ignores under tool.ruff.lint section due to the following warning:

warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'select' -> 'lint.select'
  - 'per-file-ignores' -> 'lint.per-file-ignores'

@Schefflera-Arboricola Schefflera-Arboricola changed the title MAINT: Switching to setuptools(updated pyproject.toml) MAINT: Switching to setuptools(1. updated pyproject.toml) Jun 8, 2024
@Schefflera-Arboricola Schefflera-Arboricola changed the title MAINT: Switching to setuptools(1. updated pyproject.toml) MAINT: Switching to setuptools Jun 13, 2024
@dschult
Copy link
Member

dschult commented Jun 16, 2024

Can you edit the OP in this PR to describe what this does now and how it relates to #67?
I think it would b hard for someone to come to this PR and figure out the current status of the change without more description here.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants