Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doskey is not working #428

Closed
AloisKraus opened this issue Aug 4, 2023 · 10 comments · Fixed by #437
Closed

doskey is not working #428

AloisKraus opened this issue Aug 4, 2023 · 10 comments · Fixed by #437

Comments

@AloisKraus
Copy link

When having a file with doskey macros

keys.txt

k1=echo hi
k2=echo hi2

doskey /macrofile=keys.txt
and then list the defined ones the list comes back empty when running vtm inside Windows Terminal:

With vtm
image

when doing this in a Windows Terminal cmd prompt then it works

With cmd.exe
image

No errors. That is really strange.
@o-sdn-o

This comment was marked as outdated.

Sign in to view
@AloisKraus
Copy link
Author

While you are right it might be a security flaw many developer environments set them. It is unfortunate that I cannot use vtm in developer shells. As long not everyone is using Windows Terminal there is not much we could use for cmd shell scripting.

@o-sdn-o
Copy link
Collaborator

o-sdn-o commented Aug 4, 2023

We can make this configurable and off by default.

@AloisKraus
Copy link
Author

That would be a great addition!

o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 10, 2023
@o-sdn-o
directvt#428 Reword doskey logs
74514d2
o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 11, 2023
@o-sdn-o
directvt#428 Decode condrv requests
6a83105
o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 11, 2023
@o-sdn-o
directvt#428 Decode condrv requests
8f58cfd
@o-sdn-o
Copy link
Collaborator

o-sdn-o commented Oct 11, 2023

I have now realized that this is vital functionality, and it must be implemented unconditionally.

o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 11, 2023
@o-sdn-o
directvt#428 Fix field order
66ab98c
o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 11, 2023
@o-sdn-o
directvt#428 Add/GetConsoleAlias
a5bc459
o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 11, 2023
@o-sdn-o
directvt#428 GetConsoleAliasExes/Length
ebd0ef8
o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 11, 2023
@o-sdn-o
directvt#428 GetConsoleAliases/Length
b1158f0
o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 11, 2023
@o-sdn-o
directvt#428 Decode condrv requests (command history)
e9e75aa
o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 11, 2023
@o-sdn-o
directvt#428 Decode condrv requests (SetConsoleNumberOfCommands)
11bc49e
o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 13, 2023
@o-sdn-o
directvt#428 Sync doskey macros access with input thread
9af36e9
o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 13, 2023
@o-sdn-o
directvt#428 Map doskey macros
ceed3d1
o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 13, 2023
@o-sdn-o
directvt#428 Expand doskey macros
7a81101
o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 13, 2023
@o-sdn-o
directvt#428 Alt+F10 to get rid of aliases for the current process (b…
cf1e6e6 
…y exe name)
o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 13, 2023
@o-sdn-o
directvt#428 Alt+F7 to wipe command history
a1b1b82
o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 13, 2023
@o-sdn-o
directvt#428 Input history per process name
6198542
@o-sdn-o o-sdn-o mentioned this issue Oct 13, 2023
Merged
@o-sdn-o
Copy link
Collaborator

o-sdn-o commented Oct 13, 2023

I implemented the DOSKEY functionality. You can test the branch from the pull request. I'll publish a release a little later.

o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 14, 2023
@o-sdn-o
directvt#428 Deduplicate code (consrv)
52119d1
o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 14, 2023
@o-sdn-o
directvt#428 Log when aliases/history is cleared using a shortcut
d524c81
o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 14, 2023
@o-sdn-o
directvt#428 Deduplicate code (consrv/send)
7246cd3
o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 15, 2023
@o-sdn-o
directvt#428 Add github action workflow to generate binaries (Win/Lin…
b066b3e 
…ux/macOS)
o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 15, 2023
@o-sdn-o
directvt#428 Update build.yml
5eadb90
o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 15, 2023
@o-sdn-o
directvt#428 Update build.yml
2113a94
@AloisKraus
Copy link
Author

Thanks. The test build looks good. Doskey macros are showing up now. Thanks!

@AloisKraus
Copy link
Author

My environment has VS2019, VS2022, VS2022 Preview, and VS2017 Build tools. Looks like cmake did create a solution which did target VS2019. It was targetting Build Tools 14.3, but these were not installed.

@AloisKraus
Copy link
Author

I have noticed that the new vtm when started from a Windows Terminal Session with a cmd shell

vtm -r
Not enough memory resources are available to process this command.

is showing up. The old VTM did not have this warning.

o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 16, 2023
@o-sdn-o
directvt#428 Fix GetConsoleTitle request (win32)
be95d9c
@o-sdn-o

This comment was marked as outdated.

Sign in to view
o-sdn-o added a commit to o-sdn-o/vtm that referenced this issue Oct 21, 2023
@o-sdn-o
directvt#428 Fix DOSKEY expanding (doskey test=echo $* $*)
9c20eb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement DOSKEY functionality o-sdn-o/vtm
2 participants
@o-sdn-o @AloisKraus