Improve observer list accuracy. #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the class node isn't set in the configuration for an observer, Magento will also check for the model node. Added support for this to the list command.
|
Thanks for reporting and the PR. Just a little question: What happens if none of the two are set? Are those required or optional? For the patch itself, there is a little spacing issue and you could move the logic to create that string into a private function of it's own with two parameters: $observer and $type. |
cmuench
added a commit
that referenced
this pull request
Jun 1, 2015
Improve observer list accuracy.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the class node isn't set in the configuration for an observer,
Magento will also check for the model node. Added support for this to
the list command.