Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bamarni/symfony-console-autocomplete from 1.5.4 to 1.5.5 #1270

Merged
merged 3 commits into from
Dec 22, 2022

Conversation

ktomk
Copy link
Collaborator

@ktomk ktomk commented Dec 22, 2022

Hand-picked dependency bump as automated didn't succeed.

Additionally introduces manual trigger for CI workflow and upgrades deprecated ubuntu-18.04 to ubuntu-20.04.

if in need of a button.
CI workflow spills deprecation notice:

    CI: .github#L1
    The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see actions/runner-images#6002

Change is from ubuntu-18.04 to ubuntu-20.04.
Hand-picked update of the package itself only as the PR from Dependabot
broke CI (CI netz98#231, PR netz98#1269, d8c239e).

    $ composer --version
    Composer version 2.5.1 2022-12-22 15:33:54
    $ composer update bamarni/symfony-console-autocomplete
    ...

Every phpunit test in the Code Coverage Job gave:

> Exception: Serialization of 'Closure' is not allowed

First assumption was a dependency update caused it, reviewed the
following but could not spot anything Closure related:

- symfony/polyfill-mbstring - v1.26.0 -> v1.27.0 [1]
- symfony/polyfill-php80 - v1.25.0 -> v1.27.0 [2]
- symfony/process - v4.4.41 -> v4.4.44 [3]

Changes are looking pretty maintenance only, but no formal checks, just
eyeballs.

[1]: symfony/polyfill-mbstring@v1.26.0...v1.27.0
[2]: symfony/polyfill-php80@v1.25.0...v1.27.0
[3]: symfony/process@v4.4.41...v4.4.44
@ktomk ktomk changed the title bump (actions) Bump bamarni/symfony-console-autocomplete from 1.5.4 to 1.5.5 Dec 22, 2022
@ktomk ktomk merged commit 73e8dfb into netz98:develop Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant