Finish Codecov #1273
Merged
Finish Codecov #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when ubuntu-18.04 goes away this looks pretty much as the only out of the box working Magento/Magerun version combo. The OpenMage LTS 20.0.14 PHP 8.0 (ubuntu 20.04) is experimental only, as it spills errors in the Phpunit test-suite. Failures, too. It is likely worth to add migration to a job of its own.
Back in Dec 2020 Circleci was sunset (netz98#1152) and Codecov restored. It could benefit to untangle some files still thought. Codecov is https://app.codecov.io/github/netz98/n98-magerun . This: - makes it a port to Github actions. - gets rid of circleci naming - this is now gone since two years.
Cleanup desk of today, the mysql version information is redundant in the workflow as different jobs show it and they are the standard versions: - Ubuntu 18.04: 5.7 - Ununtu 20.04: 8.0 PHP 7.3 does not support Mysql 8.0 out of the box the way we setup the passwords for magerun test installs. PHP 7.4 is not affected by that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had some tasks still open for doing finishing the circleci -> codecov | travis -> github migration.
Additionally with this PR finish and cleanup of the gone wrong move from Ubuntu 18.04 to 20.04 which I over-optimistic stressed on develop branch. At the end of the day we got: