Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command info design settings develop #534

Closed
wants to merge 22 commits into from
Closed

Command info design settings develop #534

wants to merge 22 commits into from

Conversation

LukeOl
Copy link
Contributor

@LukeOl LukeOl commented Apr 24, 2015

Hi @tkn98
I closed my previous PR and I have created new one. This time I used develop branch, instead of master branch.

Here I pasted content from previous PR:
First of all, great work guys with magerun, I can't imagine to work with Magento without Magerun :)

I have proposition of new command to Magerun pack.
I have added command to magerun, which shows current design settings on particular store view.

When developer works on Magento with one store view, he/she simply goes to configuration to obtain design settings.
If store has more than one store view, it is annoying to obtain design settings on all store views.
Command dev:theme:current will quickly show design settings to all Magento store views.

I hope this will be useful for people. I can assure you, our frontend team is pleased with this command :)

Greetz, LukeOl

qrz-io and others added 22 commits March 6, 2015 00:04
- sample-data-sql-file was not deleted (wrong parameter)
- install script path was not escaped as shell arg
- more explicit php binary commandline switches
- Fixes PHP notices about undefined array key ‘host’ when using unix
sockets.
- Fixes output of db:info command if you use a unix socket.
Also removed code which isn’t necessary anymore as it is already
checked in the detectDbSettings method.
Update ordering of compare-versions so that output is alphabetised
Windows / Git Bash Interop
Some small database connection & db:info improvements
PhpStorm autocompletion (Mac folder)
[FEATURE] new command admin:user:toggle-active
Use askHiddenResponse to hide the password by default. To maintain
backwards compatability false isn't passed as the final argument. This
means if the terminal doesn't support hidden input plain text will be
used rather than erroring. Closes #60.
Hide password when creating admin account.
Add db_prefix support to installer command.
@tkn98
Copy link
Collaborator

tkn98 commented Apr 24, 2015

Your pull request contains changes not done by yourself. This normally signals an error. Please rebase your changes against the current development branch:

Checkout your patch branch [...]:

Old PR was: #531

@LukeOl
Copy link
Contributor Author

LukeOl commented Apr 24, 2015

Hm... I did commit from my computer at work. Authors data are a bit different from github account one, but I can assure you I did this commit :)
I can remove my commit and commit with Authors appropriate to my github accounts data if it is crucial.

I have checked n98-magerun repo develop branch, and my forked repo branch has latest code of your repo develop branch.
I am not follow what I have did wrong.... :\

EDIT: I have followed your instructions from comment above. As a result of git rebase develop I got:
/www/magerun$ git rebase develop
Current branch command_info_design_settings_develop is up to date.

@pocallaghan
Copy link
Contributor

I believe it's because you have made the pull request against master, not develop. Thus all the commits on develop are showing, not just yours.

@LukeOl
Copy link
Contributor Author

LukeOl commented Apr 24, 2015

Darn, OK
Is there a way to change PR to develop, not master?

If no, then I will close this PR and create new one with correct settings...

@tkn98
Copy link
Collaborator

tkn98 commented Apr 27, 2015

@LukeOl at what @pocallaghan said.

You need to close the pull request (I do this for you) and create a new one. When you create the new one you have to specify the develop branch as where to pull against (target branch).

My fault I didn't see this earlier. ignore my previous comment, sorry for the mislead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants