Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev:module:detect-composer-dependencies: do not suggest patch levels like *.*.*-p* e.g. "^101.2.5-p5" #1358

Open
a-dite opened this issue Dec 6, 2023 · 0 comments

Comments

@a-dite
Copy link

a-dite commented Dec 6, 2023

Current Implementation

Currently the following output is possible, here with Magento 2 EE 2.4.5-p5:

`adite@bbc-web:/var/www/html$ mr2 dev:module:detect-composer-dep vendor/n98/ext.magento2.n98.mediaassets

Module: N98_MediaAssets

Directory: /var/www/html/vendor/n98/ext.magento2.n98.mediaassets

You should adjust the composer.json require section:
Recommended composer.json:
"require": {
"magento/module-backend": "^102.0.5-p2",
"magento/module-catalog": "^104.0.5-p5",
"magento/module-customer": "^103.0.5-p5",
"magento/module-downloadable": "^100.4.5",
"magento/module-integration": "^100.4.5",
"magento/module-media-storage": "^100.4.4",
"magento/module-store": "^101.1.5-p2",
"magento/module-ui": "^101.2.5",
"psr/log": "^1.1.4"
}
`

Suggested Enhancement

Suggestion is to remove the -pX suffix, as it is not crucial and sometimes makes problems, e.g. if you want to install the module on same Version, but lower patch level.

So the output in my example should look like:

`adite@bbc-web:/var/www/html$ mr2 dev:module:detect-composer-dep vendor/n98/ext.magento2.n98.mediaassets

Module: N98_MediaAssets

Directory: /var/www/html/vendor/n98/ext.magento2.n98.mediaassets

You should adjust the composer.json require section:
Recommended composer.json:
"require": {
"magento/module-backend": "^102.0.5",
"magento/module-catalog": "^104.0.5",
"magento/module-customer": "^103.0.5",
"magento/module-downloadable": "^100.4.5",
"magento/module-integration": "^100.4.5",
"magento/module-media-storage": "^100.4.4",
"magento/module-store": "^101.1.5",
"magento/module-ui": "^101.2.5",
"psr/log": "^1.1.4"
}
`

Expected Benefits

Better installability of the module on same versions of Magento 2, but with lower patch level.

cmuench added a commit to cmuench/n98-magerun2 that referenced this issue Apr 27, 2024
cmuench added a commit that referenced this issue Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant