Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOTP name wrong in Enforce MFA dialog #77

Closed
svenseeberg opened this issue Apr 23, 2024 · 7 comments
Closed

TOTP name wrong in Enforce MFA dialog #77

svenseeberg opened this issue Apr 23, 2024 · 7 comments

Comments

@beezerk23
Copy link

Hey @svenseeberg , nothing to do with your topic but maybe could you share your flow configuration to get the screenshot? Currently my configuration looks like this:
Screenshot 2024-06-03 at 08 56 29

But for some reason i only see Passkey/FIDO2 as an option to choose.

Would highly appreciate an answer :)

@melegiul
Copy link
Collaborator

melegiul commented Jun 3, 2024

Hey @beezerk23,

when you see only Passkey as an option, the reason might be that the user already set up Passkey as 2FA.
Please make sure that all 2FA methods are removed from the user account.
Then during next login, you see the 2FA enforcement dialog after you submitted the password.

See also this (in the screenshot the second subflow should be actually conditional and not required):
https://github.com/netzbegruenung/keycloak-mfa-plugins/tree/main/enforce-mfa#how-to-use-this-authenticator

@beezerk23
Copy link

Hey @melegiul, where can i check if the user has already 2FA set? Its a completely new user so i think that will not be the case but just to be sure i would like to check.

I think my configuration is exactly the same as in the screenshot you shared. Can you elaborate a bit more what i may miss?

@melegiul
Copy link
Collaborator

melegiul commented Jun 4, 2024

Yes, sure. You can make sure which 2FA are set for a user in the admin console. They would be listed under the password.

image

Another thing you should be aware of is, that the list of choices represents "required actions triggers". So you should also make sure that all related required actions are enabled on this page also in admin console: /admin/master/console/#/master/authentication/required-actions.

@beezerk23
Copy link

@melegiul That was it. I needed to activate the phone number action on required action. Now the SMS option is showing. Thanks!

@melegiul
Copy link
Collaborator

melegiul commented Jun 6, 2024

Im glad to hear that. You are welcome.

@melegiul
Copy link
Collaborator

melegiul commented Jun 6, 2024

The TOTP option seems to show a very generic title from https://github.com/keycloak/keycloak/blob/main/themes/src/main/resources-community/theme/base/email/messages/messages_de.properties#L29 instead of https://github.com/netzbegruenung/keycloak-mfa-plugins/blob/main/enforce-mfa/src/main/resources/theme-resources/messages/messages_de.properties#L5

Example: image

Yes, that is right. It seems like we must take care ourselves to avoid any key conflicts with other SPIs. Actually only themes can override.
keycloak/keycloak#11186 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants