Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing link to repository. #17

Merged
merged 3 commits into from
Jul 31, 2019
Merged

Fixed missing link to repository. #17

merged 3 commits into from
Jul 31, 2019

Conversation

fabianmarz
Copy link
Member

Description

  • Fixed missing meta informations in package.json.

Copy link
Contributor

@colourgarden colourgarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required?

@fabianmarz
Copy link
Member Author

Not strictly required but will provide additional information e.g. a link to the repo. This will help people open issues/PRs when visiting the npm page of the project.

image

vs.

image

@LucaPipolo
Copy link
Contributor

@fabianmarz — can we merge this? 😄

Copy link
Member

@sun sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase

@sun sun changed the title Fixed missing package meta informations. Fixed missing link to repository. Jul 31, 2019
@sun sun merged commit 496ff43 into master Jul 31, 2019
@sun sun deleted the fix/meta-info-fab branch July 31, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants