Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-project setup: release.dependsOn configuration should not be mandatory #19

Open
etiennestuder opened this issue Mar 18, 2015 · 7 comments

Comments

@etiennestuder
Copy link

A release block without setting the 'dependsOn' property fails the build

@netzwerg
Copy link
Owner

Could you please give more details on how it is failing?
A minimal

plugins {
  id 'ch.netzwerg.release' version '1.0.0'
}
apply plugin: 'java'

works for me.

@etiennestuder
Copy link
Author

I do not have the java plugin applied to the project where I have the release plugin applied. I have a multi-project setup, applying the release plugin to the root project (which is otherwise pretty empty). The java plugin is only applied to the sub-projects.

@netzwerg
Copy link
Owner

Thanks, Etienne. I can reproduce it in a multi-project setup and will fix it asap.

@netzwerg netzwerg changed the title release.dependsOn configuration should not be mandatory Multi-project setup: release.dependsOn configuration should not be mandatory Mar 20, 2015
@netzwerg
Copy link
Owner

I have just committed a fix which resolves the issue for my test setup. Please give it a spin and let me know whether it works for you.

Multi-project task resolution is beyond my limited Gradle knowledge -- if you see potential for improvement, a PR would be highly appreciated!

@etiennestuder
Copy link
Author

I will try it out. Though, I must say that the 'afterEvaluate' approach does not fit well when you need the processed version available sooner than that.

netzwerg added a commit that referenced this issue Apr 24, 2015
…of multi-project setup"

This approach will not be supported in Gradle 3

This reverts commit ec4e541.
@netzwerg
Copy link
Owner

I have reverted my fix because the approach of manually adding a build task will not work in Gradle 3.0 (as announced here).

Will have to think about an alternative solution...

@netzwerg
Copy link
Owner

As a workaround, please add release.dependsOn subprojects.build to your root project (after the subprojects block). I will mention this in the README until I have found a proper fix.

netzwerg added a commit that referenced this issue Apr 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants