Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to also create a release on GitHub #8

Closed
etiennestuder opened this issue Dec 20, 2014 · 8 comments
Closed

Provide option to also create a release on GitHub #8

etiennestuder opened this issue Dec 20, 2014 · 8 comments

Comments

@etiennestuder
Copy link

I'm pretty sure you can do a release on GitHub through their REST API.
To be consistent, the same versions, titles, etc. should be used (where there is an overlap).

@netzwerg
Copy link
Owner

This is a great idea! I would prefer it to be a separate plugin, though. I have created a new repo where I'm experimenting at the moment – will keep you posted...

@etiennestuder
Copy link
Author

Sounds good to me.

@netzwerg
Copy link
Owner

netzwerg commented Jan 2, 2015

I have just published a first version on Bintray. Please have a look at the README and let me know if this conceptually suits your needs.

PS: ATM the plugin is only available on jcenter, inclusion in the central Gradle plugin repo is pending...

@etiennestuder
Copy link
Author

I will give it a spin!

Once thing I'm wondering: why don't you programmatically apply the base plugin in the pub plugin? It would make the build script more concise and less potential for an accidental version conflict.

@netzwerg
Copy link
Owner

netzwerg commented Jan 2, 2015

Thanks for pointing this out. Actually, I am applying the base plugin programmatically but couldn't get the transitive resolution to work: When building the pub plugin, the base plugin is declared as a compile dependency and things work out correctly. However, when applying the pub plugin, this transitive dependency is missing when the base plugin is not applied explicitly.

@netzwerg
Copy link
Owner

netzwerg commented Jan 2, 2015

I just noticed that the compile dependency is missing in the published POM. That explains why the transitive dependency resolution doesn't work...

@etiennestuder
Copy link
Author

You have to apply the dependencies block before the plugindev block. See also:
etiennestuder/gradle-plugindev-plugin#11

This is not an intended behavior of the plugindev plugin and I will investigate the reason for this. For now, changing the order in the script acts as a work-around.

@netzwerg
Copy link
Owner

netzwerg commented Jan 3, 2015

Cool, thanks for the hint. I have changed the order and it works like a charm now!
I'm closing this issue -- feedback is welcome directly on the pub plugin repo.

@netzwerg netzwerg closed this as completed Jan 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants