Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added prefix for tagName #16

Merged
merged 2 commits into from
Jan 28, 2015
Merged

added prefix for tagName #16

merged 2 commits into from
Jan 28, 2015

Conversation

RichardGottschalk
Copy link
Contributor

I got several projects in one git repository so the tags need a prefix.
By the way, great plugin!

@RichardGottschalk
Copy link
Contributor Author

well, I don't know why the tests are failing, I do not have any groovy IDE... I hope you can add/fix those prefixes 😄

@netzwerg
Copy link
Owner

Thanks for the patch and the positive feedback!

I don't quite understand the motivation behind your addition. In Git, a tag by design always applies to the complete repository. So even if you have several projects in one repository, tagging them with a specific prefix will always tag the complete repo.

Could you elaborate on your setup/goal please?

@RichardGottschalk
Copy link
Contributor Author

just fixed the issue, sorry for that.
also added a test for the prefix.

Tags are supported by many git plugins and I think they are pretty usefull if you use a separated (maven) repository like nexus or even mavencentral for your versions.
In case you use git as repository they are indeed not required.

@netzwerg netzwerg merged commit 706d9bc into netzwerg:master Jan 28, 2015
netzwerg added a commit that referenced this pull request Jan 28, 2015
@netzwerg netzwerg added this to the 0.4.x milestone Jan 28, 2015
@netzwerg
Copy link
Owner

Merged & released, thanks again! 0.4 is up on Bintray/jCenter and should be available via Gradle Central Plugin Repository in a minute...

@RichardGottschalk
Copy link
Contributor Author

Thank you! Works perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants