This repository has been archived by the owner on Aug 18, 2018. It is now read-only.
Simplify using http-client and http-server #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @DavideAllavena! This is a good starting point to address the issue we spotted together today (i.e., that exposing a client - or a server - that by default discards the body is going to break too much the contract between the runtime and Neubot). If you could do the same for the client and also update the examples accordingly, I'd be happy to merge. |
helloimcarmine
force-pushed
the
feature/http_server_fix
branch
from
9047f49
to
bbc40b0
Compare
|
Tests are working. I check the compatibility of this patch with neubot-server. |
DavideAllavena
force-pushed
the
feature/http_server_fix
branch
from
f8c9eff
to
a38f39e
Compare
bassosimone
force-pushed
the
feature/http_server_fix
branch
from
a38f39e
to
04a6b28
Compare
bassosimone
changed the title
|
Thanks! |
bassosimone
added a commit
that referenced
this pull request
Dec 7, 2015
Simplify using http-client and http-server
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request i reamed the class HttpServer to HttpServerBase. Now HttpServer is derived from HttpServerBase the method got_request_body_piece in not empty.