forked from microsoft/code-with-engineering-playbook
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write an introduction to code reviews explaining how to make the best of a code review #4
Closed
cloudappsguy
wants to merge
12
commits into
main
from
3-create-an-introduction-to-code-reviews-explaining-how-to-make-the-best-of-a-code-review
Closed
Commits on Nov 17, 2023
-
New content for review effectiveness including a sample agenda and sample Outlook meeting template. Updated Readme content to reflect newly added review content.
Configuration menu - View commit details
-
Copy full SHA for 895a67a - Browse repository at this point
Copy the full SHA 895a67aView commit details -
added sample agenda md link to readme fixed link to agenda oft in sample agenda
Configuration menu - View commit details
-
Copy full SHA for fdbbfae - Browse repository at this point
Copy the full SHA fdbbfaeView commit details -
updated agenda email template file type
Changed from OFT to TXT file type Updated file path reference links
Configuration menu - View commit details
-
Copy full SHA for c2f0933 - Browse repository at this point
Copy the full SHA c2f0933View commit details -
Added details on psychological safety, updated link order in resources
Configuration menu - View commit details
-
Copy full SHA for adf753c - Browse repository at this point
Copy the full SHA adf753cView commit details -
Added new content for common issues discovered during code reviews; Updated Readme content and resource links; Updated sentence structure for review agenda link.
Configuration menu - View commit details
-
Copy full SHA for a7b44ed - Browse repository at this point
Copy the full SHA a7b44edView commit details -
Configuration menu - View commit details
-
Copy full SHA for 981d736 - Browse repository at this point
Copy the full SHA 981d736View commit details -
Configuration menu - View commit details
-
Copy full SHA for 481582a - Browse repository at this point
Copy the full SHA 481582aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 835b22f - Browse repository at this point
Copy the full SHA 835b22fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66dde05 - Browse repository at this point
Copy the full SHA 66dde05View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a0b07d - Browse repository at this point
Copy the full SHA 2a0b07dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 891d9d6 - Browse repository at this point
Copy the full SHA 891d9d6View commit details
Commits on Nov 30, 2023
-
verbiage change from essential to required per Cook's suggestion. Signed-off-by: Josh Nelson <11245067+cloudappsguy@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 2e722b5 - Browse repository at this point
Copy the full SHA 2e722b5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.