MPC: nullable enable and update language version to 9. #1125
+399
−570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This Pull Request is a refactoring PR.
Background
Sometimes I forget null check of
Namespace
property ofObjectSerializationInfo
.I need null-safety.
Methods
<Nullable>enable</Nullable>
and<LangVersion>9</LangVersion>
are added to theMessagePack.GeneratorCore.csproj
.All types under
src/MessagePack.GeneratorCore/CodeAnalysis/Definitions.cs
have constructor and all their properties are now get-only to ensure null-safety.src/MessagePack.GeneratorCore/Utils/RoslynExtensions.cs
' not used functions are removed because they are internal api.