Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow object that has either [MessagePackObject] or a valid [MessagePackFormatter()] #1259

Merged
merged 5 commits into from Jun 7, 2021
Merged

Allow object that has either [MessagePackObject] or a valid [MessagePackFormatter()] #1259

merged 5 commits into from Jun 7, 2021
+109 −6

Conversation

icanhasjonas
Copy link
Contributor

@icanhasjonas icanhasjonas commented Jun 3, 2021 •
edited

  • Allow object that are annotated with [MessagePackFormatter()]
  • Verify that the actual MessagePackFormatter(typeof(T)) is a valid IMessagePackFormatter (MsgPack006 diagnostic)

@icanhasjonas icanhasjonas marked this pull request as ready for review June 3, 2021 07:30
AArnott
AArnott approved these changes Jun 6, 2021
View reviewed changes
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @neuecc do you want to take a look?

We should target the develop branch since this adds new functionality in terms of an analyzer.

@AArnott AArnott changed the base branch from master to develop June 6, 2021 04:46
@AArnott AArnott added this to the v2.3 milestone Jun 6, 2021
neuecc
neuecc approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@neuecc neuecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good.

@AArnott AArnott merged commit af6d26a into MessagePack-CSharp:develop Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott approved these changes

@neuecc neuecc neuecc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@icanhasjonas @AArnott @neuecc