Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CompressionMinLength parameter to MessagePackSerializerOptions #1359

Merged
merged 2 commits into from
May 12, 2022

Conversation

israellot
Copy link
Contributor

Following the discussion here #1349

Add CompressionMinLength field to unpublished api spec
Before, it only applied to the `Lz4Block` scheme, but I don't see why we would want to apply `Lz4BlockArray` without regard to minimum length, so I've changed the library to always honor the new setting.
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. I made a couple changes. @neuecc can you review as well?

@AArnott AArnott requested a review from neuecc December 25, 2021 00:46
@AArnott
Copy link
Collaborator

AArnott commented Dec 25, 2021

@AArnott AArnott changed the base branch from master to develop December 25, 2021 01:02
@github-actions
Copy link

This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Copy link
Member

@neuecc neuecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I completely missed that.
Good feature!

@github-actions github-actions bot closed this Apr 3, 2022
@AArnott AArnott reopened this May 12, 2022
@AArnott AArnott added this to the v2.4 milestone May 12, 2022
@AArnott AArnott merged commit a70e019 into MessagePack-CSharp:develop May 12, 2022
@AArnott
Copy link
Collaborator

AArnott commented May 12, 2022

Thank you for your contribution, @israellot. Sorry it took so long to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants