Fix duplicate relative path syntax trees #635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #629
After a simple setup didn't reproduce the issue, I debugged further and noticed that the error type being used listed two possible actual types. Looking further it turned out to be caused by two references to the same project. One that was a direct relationship and one that was through another project. This resulted in two different relative paths to the same file.
Could try to detect the duplication earlier, but resolving to absolute paths at the end is simple.