Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue where messages are not built before they are used #11

Closed
wants to merge 1 commit into from

Conversation

ebretl
Copy link

@ebretl ebretl commented Oct 12, 2018

Fixes #7 better than just recompiling several times. Gencpp and genpy were not used as components

@ghost
Copy link

ghost commented Oct 12, 2018

@ebretl thanks for looking into this, I have been trying to sort this for a while. I tried your changes, but didn't seem to make much difference in the outcome, I still can't compile in the first try. I see you added genpy and gencpp, but those didn't make much difference since they are already dependencies of message_generation. I have no idea what the issue is.

@remod
Copy link

remod commented Oct 18, 2018

I think the best practice is to create a separate _msgs package, and let the driver depend on it. When creating another package which needs these messages (e.g. a user interface), it does not need to depend on the driver itself but only on the message package.

@JWhitleyWork
Copy link
Contributor

@ebretl / @shahvi - See my PR #14. It includes the fix for #7 in the currently-accepted way (gencpp and genpy are deprecated).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants