searching for the public key is now case insensitive.

[mgrossmann]

it would be nice to ignore the case while searching for keyrings

ps. my code changes belong to the same license like the original code.

[codecov]

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master      #6   +/-   ##
========================================
  Coverage      78.9%   78.9%           
  Complexity      173     173           
========================================
  Files            32      32           
  Lines           782     782           
  Branches        104     104           
========================================
  Hits            617     617           
  Misses          105     105           
  Partials         60      60

Impacted Files	Coverage Δ	Complexity Δ
bouncycastle/openpgp/keys/PGPUtilities.java	83.72% <0%> (ø)	21% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a941b03...fa2adec. Read the comment docs.

[neuhalje]

Hi Mike,

thanks for the PR!

I tested with several versions of gpg2 and cases insensitive is indeed the default behaviour.

Two minor issues:

• Please also make sure that extractSecretSigningKeyFromKeyrings and extractPublicKeyRingForUserId behave alike (your patch introduces a diverging behaviour).
• Would you mind to add matching unit tests?

[mgrossmann]

Hi Jens,

i will fix both isues.

/mig

[neuhalje]

ping :-)

[mgrossmann]

I am currently on vacation. Then I will take care of the case.

[neuhalje]

Enjoy your vacation! I did some (minor) refactorings, please don't forget to pull before continuing on the code

[mgrossmann]

I'm still alive. :) I have fixed your first request. I will try to implement the tests this week.

[neuhalje]

Hi @mgrossmann,

my reformatting of the source code made this merge very, very messy.

The easiest way would be for you to check out the current master (warning, this will force the current branch to my master, removing all your changes ) :

git fetch https://github.com/mgrossmann/bouncy-gpg.git master
git reset --hard FETCH_HEAD

and manually re-apply your commit 477c7c0:

--- a/src/main/java/name/neuhalfen/projects/crypto/bouncycastle/openpgp/keys/PGPUtilities.java
+++ b/src/main/java/name/neuhalfen/projects/crypto/bouncycastle/openpgp/keys/PGPUtilities.java
@@ -80,8 +80,9 @@ public final class PGPUtilities {
             throw new NullPointerException("publicKeyRings must not be null");
         }

-        // the true parameter indicates, that partial matching of the publicKeyUid is enough.
-        final Iterator<?> keyRings = publicKeyRings.getKeyRings("<" + publicKeyUid + ">", true);
+        // the first true parameter indicates, that partial matching of the publicKeyUid is enough.
+        // the second true parameter indicates, that matching the publicKeyUid is case insensitive.
+        final Iterator<?> keyRings = publicKeyRings.getKeyRings("<" + publicKeyUid + ">", true, true);
         PGPPublicKeyRing returnKeyRing = null;
         while (keyRings.hasNext()) {
             final Object currentKeyRing = keyRings.next();

Sorry for the inconvenience

[neuhalje]

Hi, any progress on the test? Cheers!

[mgrossmann]

Gesundes neues Jahr. Leider noch nicht, aber die guten Vorsätze beinhalten auch die Tests. VG

…

On 2. Jan. 2018, 08:37 +0100, Jens Neuhalfen ***@***.***>, wrote: Hi, any progress on the test? Cheers! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[neuhalje]

Implemented in Rfc4880KeySelectionStrategy