Skip to content

Commit

Permalink
allow ensembling of models without source vocabulary
Browse files Browse the repository at this point in the history
  • Loading branch information
msperber committed May 15, 2018
1 parent 421850e commit 8f807bb
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions xnmt/translator.py
Original file line number Diff line number Diff line change
Expand Up @@ -512,8 +512,9 @@ def __init__(self, models, src_reader, trg_reader, inference=bare(SimpleInferenc

# perform checks to verify the models can logically be ensembled
for i, model in enumerate(self.models):
assert self.src_reader.vocab.is_compatible(model.src_reader.vocab), \
f"src_reader.vocab is not compatible with model {i}"
if hasattr(self.src_reader, "vocab") or hasattr(model.src_reader, "vocab"):
assert self.src_reader.vocab.is_compatible(model.src_reader.vocab), \
f"src_reader.vocab is not compatible with model {i}"
assert self.trg_reader.vocab.is_compatible(model.trg_reader.vocab), \
f"trg_reader.vocab is not compatible with model {i}"

Expand Down

0 comments on commit 8f807bb

Please sign in to comment.