Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Korean Translation #42

Closed
soobing opened this issue Mar 15, 2021 · 3 comments
Closed

Added Korean Translation #42

soobing opened this issue Mar 15, 2021 · 3 comments

Comments

@soobing
Copy link

soobing commented Mar 15, 2021

I translated micro-frontend into Korean.
Can I use domain with github pages?

These are should be added.

<link rel="alternate" hreflang="ko" href="https://soobing.github.io/micro-frontends/" />
<a href="https://soobing.github.io/micro-frontends/">KR</a>
- [Soobin Bak](https://github.com/soobing) who translated the site to [Korean](https://soobing.github.io/micro-frontends/).

Thanks for nice article with examples 👍🏻

@soobing
Copy link
Author

soobing commented Mar 16, 2021

@naltatis Hi ~~~ 😃

@naltatis
Copy link
Member

Hi @soobing, thanks for the translation. I'll add the references later today.
And yes, using a GitHub pages domain is perfectly fine for me.

@naltatis
Copy link
Member

I've added the references. Thanks for your work @soobing! 🍒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants