Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pull_request_template.md #46

Closed
wants to merge 1 commit into from
Closed

Create pull_request_template.md #46

wants to merge 1 commit into from

Conversation

victoriacheng15
Copy link

@victoriacheng15 victoriacheng15 commented May 25, 2022

As the title suggested, added a pull request template for the repo.

For the checklist, I am not how much requirement you would like to see, but I listed 3 for now. This can always improve or adjust as the project is growing.

Let me know if you have anything else to add or feedback.

Close #43

@TimDaub
Copy link
Collaborator

TimDaub commented Jun 2, 2022

@il3ven I'm assigning you to sort this out. I'll go with your judgment.

@il3ven
Copy link
Contributor

il3ven commented Jun 2, 2022

@TimDaub My honest opinion is that we don't need a template. It's a solution for a problem we don't have. Let people structure the description of the PR however they want. The other use of the template is the checklist but we already have a CI for that.

@TimDaub If you disagree with me, no problem. All this is very subjective. We can re-open this PR.

@victoriacheng15 Thank you for your contribution. We appreciate it but sorry for closing this. If you are looking to make more contributions we have a few good first issue in the neume-network repository. May I recommend neume-network/strategies#41.

@il3ven il3ven closed this Jun 2, 2022
@TimDaub
Copy link
Collaborator

TimDaub commented Jun 2, 2022

actually I agree with you. We don't have a problem with PR descriptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add pull request template
3 participants