New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When someone adds new code in a PR and no tests, CI makes them pass #174

Open

TimDaub opened this issue Jul 11, 2022 · 0 comments

Labels

bug

Collaborator

TimDaub commented Jul 11, 2022

E.g. someone can make a PR and propose a new functionality but it may be that they don't contribute any tests to this functionality.
Still, our CI makes their change set "pass" and everything looks green. But in reality our painstakingly collected test coverage goes down
hence CI should stop any contributor that doesn't at least maintains current code coverage percentage

TimDaub added the bug label

TimDaub mentioned this issue

upgrade lifecycle handler #168

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment