Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code quality issues #24

Closed
wants to merge 1 commit into from
Closed

fix code quality issues #24

wants to merge 1 commit into from

Conversation

withshubh
Copy link

Hi, I ran DeepSource analysis on my fork of this repository and found some interesting code quality issues which you might want to fix. Take a quick look at all the issues caught by DeepSource for this repository here

Summary of changes:

  • Remove unnecessary comprehension
  • Remove implicit object from the base class
  • Added .deepsouce.toml config

DeepSource is a code review automation tool that detects code quality issues and helps you to automatically fix some of them. You can use DeepSource to track test coverage, Detect problems in Dockerfiles, etc. in addition to detecting issues in code.
All the features of the DeepSource are mentioned here.

I'd suggest you integrate DeepSource since it is free for Open Source projects forever.

@davidmezzetti
Copy link
Member

Thank you for submitting this.

I fully understand and appreciate you're trying to promote your product/company but I am not going to merge this in right now. At some point, I may consider integrating it but not right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants