Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

could not import zoo #484

Open
mammadmaheri7 opened this issue May 1, 2024 · 4 comments
Open

could not import zoo #484

mammadmaheri7 opened this issue May 1, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@mammadmaheri7
Copy link

Hi,

I encounter an error when I try to import ScheduledModifierManager:

versions:
sparsezoo-nightly: 1.5.0.20230531
sparseml-nightly: 1.5.4.20240501

code:
from sparseml.pytorch.optim import ScheduledModifierManager

log of error:
Traceback (most recent call last):
File "", line 1, in
File "/rds/general/user/mm6322/home/anaconda3/envs/CAP_new_new/lib/python3.9/site-packages/sparseml_nightly-1.5.4.20240501-py3.9.egg/sparseml/init.py", line 33, in
from .framework import (
File "/rds/general/user/mm6322/home/anaconda3/envs/CAP_new_new/lib/python3.9/site-packages/sparseml_nightly-1.5.4.20240501-py3.9.egg/sparseml/framework/init.py", line 22, in
from .info import *
File "/rds/general/user/mm6322/home/anaconda3/envs/CAP_new_new/lib/python3.9/site-packages/sparseml_nightly-1.5.4.20240501-py3.9.egg/sparseml/framework/info.py", line 55, in
from sparseml.sparsification.info import SparsificationInfo
File "/rds/general/user/mm6322/home/anaconda3/envs/CAP_new_new/lib/python3.9/site-packages/sparseml_nightly-1.5.4.20240501-py3.9.egg/sparseml/sparsification/init.py", line 22, in
from .analyzer import *
File "/rds/general/user/mm6322/home/anaconda3/envs/CAP_new_new/lib/python3.9/site-packages/sparseml_nightly-1.5.4.20240501-py3.9.egg/sparseml/sparsification/analyzer.py", line 26, in
from sparseml.optim import default_pruning_sparsities_loss
File "/rds/general/user/mm6322/home/anaconda3/envs/CAP_new_new/lib/python3.9/site-packages/sparseml_nightly-1.5.4.20240501-py3.9.egg/sparseml/optim/init.py", line 23, in
from .helpers import *
File "/rds/general/user/mm6322/home/anaconda3/envs/CAP_new_new/lib/python3.9/site-packages/sparseml_nightly-1.5.4.20240501-py3.9.egg/sparseml/optim/helpers.py", line 35, in
from sparsezoo import Zoo
ImportError: cannot import name 'Zoo' from 'sparsezoo' (/rds/general/user/mm6322/home/anaconda3/envs/CAP_new_new/lib/python3.9/site-packages/sparsezoo_nightly-1.5.0.20230531-py3.9.egg/sparsezoo/init.py)

@mammadmaheri7 mammadmaheri7 added the bug Something isn't working label May 1, 2024
@mgoin
Copy link
Member

mgoin commented May 1, 2024

Hey @mammadmaheri7 , those versions are from our 1.5 nightly version which is quite old at this point, and the nightly versions don't match exactly. Could you try upgrading them to the latest version or forcing them to match the same dated version?

@mammadmaheri7
Copy link
Author

As I trying to reproduce the result of recent published paper, they've implemented their codes based on older version of sparsezoo and updating sparsezoo will end up inconstancy. So upgrading sparsezoo is not possible.

@mammadmaheri7
Copy link
Author

Also, I've tried latest version of sparsezoo (1.7.0) but still I encountered the same error:

trace:

Traceback (most recent call last):
File "one_shot_pruning.py", line 21, in
from sparseml.pytorch.optim import ScheduledModifierManager
File "/rds/general/user/mm6322/home/anaconda3/envs/CAP_final/lib/python3.8/site-packages/sparseml-1.7.0-py3.8.egg/sparseml/init.py", line 33, in
from .framework import (
File "/rds/general/user/mm6322/home/anaconda3/envs/CAP_final/lib/python3.8/site-packages/sparseml-1.7.0-py3.8.egg/sparseml/framework/init.py", line 22, in
from .info import *
File "/rds/general/user/mm6322/home/anaconda3/envs/CAP_final/lib/python3.8/site-packages/sparseml-1.7.0-py3.8.egg/sparseml/framework/info.py", line 55, in
from sparseml.sparsification.info import SparsificationInfo
File "/rds/general/user/mm6322/home/anaconda3/envs/CAP_final/lib/python3.8/site-packages/sparseml-1.7.0-py3.8.egg/sparseml/sparsification/init.py", line 22, in
from .analyzer import *
File "/rds/general/user/mm6322/home/anaconda3/envs/CAP_final/lib/python3.8/site-packages/sparseml-1.7.0-py3.8.egg/sparseml/sparsification/analyzer.py", line 26, in
from sparseml.optim import default_pruning_sparsities_loss
File "/rds/general/user/mm6322/home/anaconda3/envs/CAP_final/lib/python3.8/site-packages/sparseml-1.7.0-py3.8.egg/sparseml/optim/init.py", line 23, in
from .helpers import *
File "/rds/general/user/mm6322/home/anaconda3/envs/CAP_final/lib/python3.8/site-packages/sparseml-1.7.0-py3.8.egg/sparseml/optim/helpers.py", line 35, in
from sparsezoo import Zoo
ImportError: cannot import name 'Zoo' from 'sparsezoo' (/rds/general/user/mm6322/home/anaconda3/envs/CAP_final/lib/python3.8/site-packages/sparsezoo-1.7.0-py3.8.egg/sparsezoo/init.py)

@bfineran
Copy link
Member

Hi @mammadmaheri7 can you maybe start from a clean environment? It looks like the import that it's failing on is quite old (even before 1.5) and is not up to date with what is in the 1.5 branch even. This also definitely should not be getting hit in 1.7 which leads me to believe there may be a local environment issue. Maybe it's anaconda? Our testing is done only through pip.

see the updated import on the 1.5 branch: https://github.com/neuralmagic/sparseml/blob/28894c3fcd87ea7cfca5101189d0ffb2c64a3e6f/src/sparseml/optim/helpers.py#L35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants