Fix missing parameters output_scaling_factor #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleepyeye
changed the title
|
Also I set |
|
Great, thanks @sleepyeye! @ashiq24 for visibility as you're working on the scaling factor. |
ziqi-ma
pushed a commit
to ziqi-ma/neuraloperator
that referenced
this pull request
Aug 29, 2023
…ssing-parameters Fix missing parameters output_scaling_factor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fix missing
output_scaling_factorparameter in the constructor ofFNO1d,FNO2dand,FNO3d. Also it fix inconsistent parameter nameoutput_scale_factortooutput_scaling_factorinDomainPaddingclass.I found the
output_scaling_factoronly working withFNOclass.However, it didn't work with
FNO1d,FNO2dand,FNO3dsince__init__ofFNO1d,FNO2d,FNO3ddoes not haveoutput_scaling_factor.Also,
DomainPaddingclass utilizes theoutput_scaling_factorwith different name notoutput_scaling_factor. Thus I renamed it tooutput_scaling_factor.