Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loss signatures to build doc #224

Merged
merged 12 commits into from
Sep 25, 2023
Merged

Fix loss signatures to build doc #224

merged 12 commits into from
Sep 25, 2023

Conversation

dhpitt
Copy link
Collaborator

@dhpitt dhpitt commented Sep 25, 2023

Doc now builds successfully.

Changes

  • change default loss signature to take arguments y_pred, y
  • change Trainer to only send required arguments to model.forward()
  • change SFNO training example to cpu-only (temp fix)

@JeanKossaifi JeanKossaifi merged commit d2aaf7c into neuraloperator:main Sep 25, 2023
1 check passed
@JeanKossaifi
Copy link
Member

Thanks @dhpitt! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhpitt @JeanKossaifi