Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in checkpoint init #241

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

rybchuk
Copy link
Contributor

@rybchuk rybchuk commented Oct 18, 2023

There's a typo in the new checkpoint Callbacks, super().__init() instead of super().__init__(). When the Callbacks are run, they produce an error: AttributeError: 'super' object has no attribute '_ModelCheckpointCallback__init'. After this fix, I successfully ran a job and generated checkpoint files.

@JeanKossaifi
Copy link
Member

Thanks @rybchuk! @dhpitt let's add some unit-tests for the callbacks to make sure they work as expected. We can use pytest to mock the save file.

@JeanKossaifi JeanKossaifi merged commit e2fa9e4 into neuraloperator:main Oct 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants