-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to DataProcessor API #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, thanks @dhpitt! I think we still need to polish a little the overall interface.
@@ -225,16 +225,16 @@ def on_val_end(self, *args, **kwargs): | |||
for c in self.callbacks: | |||
c.on_val_end(*args, **kwargs) | |||
|
|||
class SimpleWandBLoggerCallback(Callback): | |||
class BasicLoggerCallback(Callback): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not BasicWandbCallback?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logger is capable of logging to stdout
when wandb_log = false
Thanks @dhpitt, merging! |
This PR makes the following changes:
DataProcessor
object that replaces thetorchvision.Transforms
approach to applying transforms inside datasetsdarcy
andnavier_stokes
datasets to returnDataProcessor
objectsTransform
object fromoutput_encoder.py
totransforms.py
and makes it an abstract base classCallback
classes that implement data preprocessing/postprocessing and changes them intoDataPipeline
classesWandBLoggerCallback
toBasicLoggerCallback