Fix tests #121
Merged
Fix tests #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atemate
commented
Oct 21, 2020
Comment on lines
+80
to
+83
| if out: | ||
| logger.debug(f"Stdout:\n{SEP_BEGIN}\n{out}\n{SEP_END}\nStdout finished") | ||
| if err: | ||
| logger.debug(f"Stderr:\n{SEP_BEGIN}\n{err}\n{SEP_END}\nStderr finished") |
There was a problem hiding this comment.
make tests less noisy
atemate
commented
Oct 21, 2020
| @@ -50,7 +51,7 @@ def project_dir() -> Iterator[Path]: | |||
|
|
|||
| @pytest.fixture() | |||
| def cli_runner(capfd: CaptureFixture[str], project_dir: Path) -> CLIRunner: | |||
| def _run_cli(args: List[str]) -> CompletedProcess: # type: ignore | |||
| def _run_cli(args: List[str]) -> "CompletedProcess[str]": | |||
There was a problem hiding this comment.
fix typing instead of ignoring it
atemate
commented
Oct 21, 2020
| @@ -855,9 +888,8 @@ def test_data_cp_from_cloud_to_storage( | |||
| @pytest.fixture | |||
| def disk(cli_runner: CLIRunner) -> Iterator[str]: | |||
| # Create disk | |||
| res = cli_runner(["neuro", "disk", "create", "1G"]) | |||
| res = cli_runner(["neuro", "disk", "create", "100M"]) | |||
There was a problem hiding this comment.
no need to get 1G. These tests run in parallel, each run will require 1G, so they will conflict.
added 2 commits
October 21, 2020 19:05
|
merging w/out review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sleep 10v20.10.16a1->a3acb3c3dfeabbb01292c3a441f4bf03efd041e5because it contains this part required by gcp. This will be changed in the following-up releases, so this change is temp.disk:to get readytest_seldon_deploy_from_local(see Uncomment image building in test_seldon_deploy_from_local #123)