Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade fluent-bit #842

Merged
merged 9 commits into from
Oct 18, 2023
Merged

upgrade fluent-bit #842

merged 9 commits into from
Oct 18, 2023

Conversation

zubenkoivan
Copy link
Contributor

@zubenkoivan zubenkoivan commented Oct 13, 2023

Closes #837

Fluent Bit in recent versions introduced new AWS S3 plugin which is able to put logs directly to object storage. Currently we use Fluentd to forward logs to object storage.

PR contains following changes:

  • Fluent Bit upgrade
  • Switched Fluent Bit to use s3 plugin for output
  • Removed Fluentd
  • For GCP and Azure object storages deploy Minio gateway service to conform them to S3 API
  • Make integration tests more stable

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #842 (aaaaa8e) into master (061c989) will decrease coverage by 0.65%.
Report is 2 commits behind head on master.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
- Coverage   86.41%   85.76%   -0.65%     
==========================================
  Files          12       12              
  Lines        2090     2100      +10     
  Branches      289      290       +1     
==========================================
- Hits         1806     1801       -5     
- Misses        173      187      +14     
- Partials      111      112       +1     
Flag Coverage Δ
integration 79.80% <69.23%> (-0.77%) ⬇️
unit 47.23% <23.07%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
platform_monitoring/logs.py 84.94% <100.00%> (-2.59%) ⬇️
platform_monitoring/api.py 81.33% <66.66%> (-0.45%) ⬇️

@zubenkoivan zubenkoivan marked this pull request as ready for review October 17, 2023 13:44
Copy link
Contributor

@dalazx dalazx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great. how will this solution handle existing old logs in all our clusters?

@zubenkoivan
Copy link
Contributor Author

Changes are backward compatible. S3 plugin writes log files with the same S3 key prefix /$TAG/%Y%m%d%H%M as Fluentd did before, so S3LogReader will be able to parse old and new logs the same way and sort them correctly.

@dalazx
Copy link
Contributor

dalazx commented Oct 18, 2023

excellent. thank you!

@zubenkoivan zubenkoivan merged commit d192235 into master Oct 18, 2023
8 of 10 checks passed
@zubenkoivan zubenkoivan deleted the iz/upgrade-fluent-bit branch October 18, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade fluentbit to the latest version
2 participants