Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle invalid unicode in logs #846

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Conversation

zubenkoivan
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #846 (5d8eeb4) into master (0cd8213) will increase coverage by 0.19%.
The diff coverage is 92.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #846      +/-   ##
==========================================
+ Coverage   85.76%   85.95%   +0.19%     
==========================================
  Files          12       12              
  Lines        2100     2143      +43     
  Branches      290      296       +6     
==========================================
+ Hits         1801     1842      +41     
- Misses        187      188       +1     
- Partials      112      113       +1     
Flag Coverage Δ
integration 79.51% <71.21%> (-0.54%) ⬇️
unit 48.11% <75.75%> (+0.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
platform_monitoring/logs.py 86.08% <98.30%> (+1.14%) ⬆️
platform_monitoring/api.py 81.37% <42.85%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

@zubenkoivan zubenkoivan marked this pull request as ready for review October 21, 2023 08:24
Copy link
Contributor

@dalazx dalazx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zubenkoivan zubenkoivan merged commit 473f39b into master Oct 23, 2023
10 checks passed
@zubenkoivan zubenkoivan deleted the iz/handle-invalid-unicode branch October 23, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants