Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check that input graph is same size as P matrix when using score in the model selection code #216

Closed
bdpedigo opened this issue Jun 26, 2019 · 1 comment · Fixed by #231
Closed

check that input graph is same size as P matrix when using score in the model selection code #216

bdpedigo opened this issue Jun 26, 2019 · 1 comment · Fixed by #231
Assignees
@bdpedigo

Comments

@bdpedigo
Copy link
Collaborator

No description provided.

@bdpedigo bdpedigo self-assigned this Jun 26, 2019
@bdpedigo bdpedigo added this to the GraSPy 0.0.4 milestone Jul 12, 2019
@bdpedigo
Copy link
Collaborator Author

https://github.com/neurodata/graspy/blob/065eccfbe585304275f72ae3e6f65f929cb26095/graspy/models/base.py#L83

in the function score_sample, the user inputs a graph to check whether the likelihood of the input graph given the fit model. As currently implemented, this only works when the input graph is the same size as p_mat_. There should be an input check that throws an error if input graph and p_mat_ are not the same size.

@shiyussy shiyussy mentioned this issue Jul 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdpedigo bdpedigo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix input protection for score method graspologic-org/graspologic
1 participant
@bdpedigo