Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Run gave nothing, not results, no errors too. #178

Closed
hahaai opened this issue Nov 1, 2018 · 10 comments
Closed

Docker Run gave nothing, not results, no errors too. #178

hahaai opened this issue Nov 1, 2018 · 10 comments

Comments

@hahaai
Copy link

hahaai commented Nov 1, 2018

Hi,

This is Lei Ai from the Child Mind Institute. I pulled the docker image and tried to run some dataset (BIDS format), but a few seconds after running the following commands, it 'finished/stopped.', no errors and output.

Command run:

Outsied the docker:
docker run -ti --name ndmg_test --rm -v $datain:/home/data bids/ndmg /home/data/ /home/data/outputs participant --participant_label 10001

Goign into the docker and run Inside:
docker run -ti -v $datain:/home/data --entrypoint /bin/bash bids/ndmg
ndmg_bids /home/data /home/data/output participant --participant_label 10001

$datain is the bids format dataset. I have tried with and without the "--participant_label", there had the same problem.

Thank you very much.

Best,
Lei

@gkiar
Copy link
Collaborator

gkiar commented Nov 1, 2018 via email

@hahaai
Copy link
Author

hahaai commented Nov 1, 2018

I did it the first time when it was not working, the actual data was there. Though I only have anatomical and functional data.

I also run the ndmg_demo_dwi, it worked. This demo created one subject data. Then I run this sample subject the same way I run my own data, and it worked!

The sample data is just in bids format and I don’t see any difference with my own dataset. I noticed it
has dwi data, so I get another dataset with dwi, but still the same problem.

I did notice that when I first tried, my dataset was not in bids format, and the pipeline complained and gave errors. But once I input BIDS dataset, it has that problem.

Thanks.

@ebridge2
Copy link
Collaborator

ebridge2 commented Nov 1, 2018

Hi @hahaai which docker container are you using? It looks like you are using ndmg which only works with some types of bids-spec'ing, and also does not include functional MRI analysis (diffusion only). Is this correct?

Can you show the result of the following command:

tree -d </path/to/your/bids/data>

as well as the version of the docker container you are using, to confirm my suspicion?

@hahaai
Copy link
Author

hahaai commented Nov 2, 2018

@ebridge2 Thanks.
Here is one of my sample dataset tree.
screen shot 2018-11-01 at 9 06 49 pm
Information about hte docker container. It seems it is a old one. What about the neurodata/ndmg?
REPOSITORY TAG IMAGE ID CREATED SIZE

bids/ndmg latest 38f48d5df135 9 months ago 2.04GB

Thank you very much.

@gkiar
Copy link
Collaborator

gkiar commented Nov 2, 2018

Hi @hahaai, the problem is your dataset has ses spelled incorrectly - there is an extra s in yours. Remove that and it should work fine.

@ebridge2
Copy link
Collaborator

ebridge2 commented Nov 2, 2018 via email

@ebridge2
Copy link
Collaborator

ebridge2 commented Nov 2, 2018

@hahaai try this:

Pull docker container:

docker pull neurodata/m3r-release:0.1.1

Download/unpack bids data (note you must have aws cli installed):

aws s3 cp --no-sign-request s3://mrneurodata/bids_test.tar.gz ./
tar -xvzf ./bids_data.tar.gz

Run fmri pipeline:

docker run -ti -v </path/local>/BIDs_test:/inputs -v </path/local/out>:/outputs neurodata/m3r-release:0.1.1 /inputs /outputs participant func --stc interleaved --nproc <ncores>

Run dmri pipeline:

docker run -ti -v </path/local>/BIDs_test:/inputs -v </path/local/out>:/outputs neurodata/m3r-release:0.1.1 /inputs /outputs participant dwi --nproc <ncores>

where all items in <> are for you to replace.

@ebridge2
Copy link
Collaborator

ebridge2 commented Nov 6, 2018

Hey @hahaai have you had a chance to take a stab at the above example, and see if the m3r-release:0.1.1 container fixes issues for you? Let me know. Want to close the loop on this this week, if possible.

@hahaai
Copy link
Author

hahaai commented Nov 30, 2018

Thanks. That worked after changed one thing:

docker run -ti -v </path/local>/BIDs_test:/inputs -v </path/local/out>:/outputs neurodata/m3r-release:0.1.1 /inputs /outputs participant -- modality func --stc interleaved --nproc

Another question, is that possible to do global regression?

@ebridge2
Copy link
Collaborator

ebridge2 commented Nov 30, 2018

Hi @hahaai; yes, I made some changes last week to make it more compliant with BIDs containers since I last posted that comment, one of which was the flag change you found, so I apologize for not updating the issue accordingly!

Re: GSR
our goal with ndmg is to produce a consistent pipeline that is effective for all forms of fMRI. Every time a preprocessing step is added, the results are biased for that particular preprocessing method. For instance, if we were to analyze a dataset where a parameter (ie, a registration method that works better for one dataset, but not another, for instance, so we have an option to change around registration protocols included) the results produced between the two datasets can no longer be compared.

When we designed ndmg, our goal was to create a preprocessing pipeline suitable for most datasets as reliably as possible, so that aggregated inference could be performed without the afforementioned issues. When we made the decision to skip over gsr, that decision was made because when analyzing task fMRI, gsr basically destroyed a large component of the signal present using many common task fMRI analysis techniques.

Recently, we are looking at adding a limited suite of command line options (such as whether or not to perform gsr; particularly, we found gsr to perform awesomely for resting state data, so this is why we are considering adding it back), but no decisions have been made yet. Your thoughts of why: to include gsr vs to not include gsr are much appreciated. Stay tuned!

@loftusa loftusa closed this as completed May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants