Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension module no specs found #50

Closed
ajtritt opened this issue Aug 3, 2017 · 4 comments
Closed

extension module no specs found #50

ajtritt opened this issue Aug 3, 2017 · 4 comments
Labels
category: bug errors in the code or code behavior priority: high impacts proper operation or use of feature important to most users

Comments

@ajtritt
Copy link
Member

ajtritt commented Aug 3, 2017

Originally reported by: nicholasc@alleninstitute.org (Bitbucket: nicholashcain, GitHub: Unknown)


MRE at gist:

https://gist.github.com/nicain/65dd4758590641af1f612827a4b467a2


@ajtritt
Copy link
Member Author

ajtritt commented Aug 3, 2017

Original comment by Oliver Ruebel (Bitbucket: oruebel, GitHub: oruebel):


In your script, please replace NWBDatasetSpec with NWBGroupSpec. You are creating an extension that inherits from TimeSeries which is a specification of a group, not a dataset. I gave it a quick test, and once I replace NWBDatasetSpec with NWBGroupSpec, it works.

I'll add an issue that we need to add a check for this problem when creating the spec.

@ajtritt
Copy link
Member Author

ajtritt commented Aug 3, 2017

Original comment by nicholasc@alleninstitute.org (Bitbucket: nicholashcain, GitHub: Unknown):


Thanks Oliver, Im following through on your suggestion now.

@ajtritt
Copy link
Member Author

ajtritt commented Aug 3, 2017

Original comment by nicholasc@alleninstitute.org (Bitbucket: nicholashcain, GitHub: Unknown):


OK, I tried your suggestion, and hit a different snag:

https://gist.github.com/nicain/9f03154823678fc74fed674913fb08ee

Before I make an issue, can you confirm that I am not doing something silly? "data" was defined on line 30. Just hit me with a comment and Ill make and issue if I'm not just being clumsy. Also @ajtritt, did we come across a version of this at the hackathon?

@ajtritt
Copy link
Member Author

ajtritt commented Aug 3, 2017

Original comment by Andrew Tritt (Bitbucket: ajtritt, GitHub: ajtritt):


@nicholashcain Are you trying to add an attribute to the 'data' dataset? Or, are you trying to add an attribute to your new type? If you are trying to do the former you should do something like this:

nwb_ds = NWBDatasetSpec('a spec to add an attribute to TimeSeries.data',
                        name='data',
                        attributes=[
                            NWBAttributeSpec('gid', 'int', 'the group_id for the neuron')
                        ])

@ajtritt ajtritt added priority: high impacts proper operation or use of feature important to most users category: bug errors in the code or code behavior labels Aug 3, 2017
@ajtritt ajtritt closed this as completed Aug 3, 2017
ajtritt added a commit that referenced this issue Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior priority: high impacts proper operation or use of feature important to most users
Projects
None yet
Development

No branches or pull requests

1 participant