Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rphylopic failing #28

Closed
bschilder opened this issue Mar 14, 2023 · 3 comments
Closed

rphylopic failing #28

bschilder opened this issue Mar 14, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@bschilder
Copy link
Collaborator

bschilder commented Mar 14, 2023

rphylopic is failing to run any of its examples, perhaps due to a change in the phylopic API.

library(rphylopic)
name_search(text = "Homo sapiens")
Error: Not Found (HTTP 404)

This causes orthogene to fail:
https://master.bioconductor.org/checkResults/3.17/bioc-LATEST/orthogene/nebbiolo1-checksrc.html

It may be the case that the development version of rphylopic (1.0.0) has since resolved this, but the latest CRAN release is rather behind (0.3.0). Will ping the maintainer to ask them to updated the CRAN version, which is required for Bioc packages.

@bschilder bschilder added the bug Something isn't working label Mar 14, 2023
@bschilder bschilder self-assigned this Mar 14, 2023
@bschilder
Copy link
Collaborator Author

The fix to rphylopic should be available on CRAN soon.

But there's still issues with ggtree, and ggimage which it relies on. ggimage has not yet updated to the new phylopic API...
Hopefully the authors will merge this PR ASAP, as the next bioc deadline is fast approaching:
GuangchuangYu/ggimage#45

@bschilder
Copy link
Collaborator Author

Tried a workaround method by using geom_tiplab2(geom="image",...), but this caused other errors:
YuLab-SMU/ggtree#566

@bschilder
Copy link
Collaborator Author

rphylopic is now fixed and pushed to CRAN:
palaeoverse/rphylopic#39

Now just waiting for ggtree and ggimage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant