Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN checks: Packages required but not available: 'biocViews', 'BiocPkgTools' #65

Closed
bschilder opened this issue Aug 31, 2023 · 11 comments
Assignees
Labels
bug Something isn't working CRAN Issue related to the CRAN server

Comments

@bschilder
Copy link
Collaborator

CRAN checks are failing when using R devel:
https://cran.r-project.org/web/checks/check_results_rworkflows.html

All errors are due to the following:

Packages required but not available: 'biocViews', 'BiocPkgTools'

biocViews is actually fine on Bioc devel. So not sure why CRAN is reporting a problem.
https://bioconductor.org/packages/devel/bioc/html/biocViews.html

But BiocPkgTools is indeed failing on devel. I've notified the maintainers and hopefully they'll fix this soon.
https://bioconductor.org/packages/devel/bioc/html/BiocPkgTools.html

@bschilder bschilder added the bug Something isn't working label Aug 31, 2023
@bschilder bschilder self-assigned this Aug 31, 2023
@bschilder
Copy link
Collaborator Author

Fix was made, just waiting for updates to propagate to Bioc devel --> CRAN.
seandavi/BiocPkgTools#70 (comment)

@bschilder
Copy link
Collaborator Author

bschilder commented Sep 4, 2023

Fixes have propagated to Bioc, but CRAN is still showing the errors.

I reached out to the CRAN team, was told to find the guy who handles Mac problems. Found him, but he's on leave for an unknown period of time. Asked for a secondary contact to address this.

@bschilder
Copy link
Collaborator Author

Since I still haven't heard back form the CRAN maintainer, and there appears to be no secondary personnel who can handle this, I've decided to go the route of removing these pkgs as hard deps. Will push to dev and if all goes well, will merge with master.

@bschilder bschilder added the CRAN Issue related to the CRAN server label Sep 12, 2023
@bschilder
Copy link
Collaborator Author

bschilder commented Sep 14, 2023

Merged dev --> master and submitted rworkflows v0.99.13 to CRAN. Just waiting for checks to finish.

@bschilder
Copy link
Collaborator Author

bschilder commented Sep 15, 2023

So despite the CRAN reviewer's suggestion, changing 'biocViews'/'BiocPkgTools' from Imports to Suggests did not remove the Note.

What's more, there are new errors regarding pandoc missing (a very standard system dep for most R packages). It seems the CRAN servers are a bit of a mess lately, and the only option is for me to wait until someone fixes it on their end.

https://cran.r-project.org/web/checks/check_results_rworkflows.html

@bschilder
Copy link
Collaborator Author

So despite the CRAN reviewer's suggestion, changing 'biocViews'/'BiocPkgTools' from Imports to Suggests did not remove the Note.

I've asked the Mac VM maintainer at CRAN to install these. Waiting for a reply.

What's more, there are new errors regarding pandoc missing (a very standard system dep for most R packages). It seems the CRAN servers are a bit of a mess lately, and the only option is for me to wait until someone fixes it on their end.

https://cran.r-project.org/web/checks/check_results_rworkflows.html

I flagged with the Mac VM maintainer at CRAN, and he has fixed it.

There are also some new errors on CRAN, which I've logged here: #77

@bschilder
Copy link
Collaborator Author

I believe it was @aedin that recently suggested to me to try adding the Bioc repos to the .Rprofile. You can even control installation repo priority this way. Will give this a go and see if it helps!

@bschilder
Copy link
Collaborator Author

bschilder commented Nov 1, 2023

I've added an .Rprofile to try and resolve this. Everything passes locally, will push to CRAN and see if it helps there.

This assumes BiocManager is already installed, which is only the case when using the bioc docker on Linux (the other OS fail):

options(repos = BiocManager::repositories())

Instead, I've copied the output and hard-coded it:

options(repos = c(BioCsoft = "https://bioconductor.org/packages/3.18/bioc",

@bschilder
Copy link
Collaborator Author

Just submitted rworkflows 1.0.0 to CRAN 🤞

@bschilder
Copy link
Collaborator Author

Had to make some final edits to the Roxygen notes to comply with some new CRAN standards:

  • Change \itemize --> describe to avoid CRAN check errors.

But after that, all checks passed and rworkflows 1.0.0 was approved autoamtically! Should be on CRAN within the next day or so:

Image

@bschilder
Copy link
Collaborator Author

bschilder commented Nov 3, 2023

Only about half of the runners on CRAN seem to be using rworkflow 1.0.0. Hopefully this is just due to a lag in when those machines are rerun and it resolves itself in time.
https://cran.r-project.org/web/checks/check_results_rworkflows.html

Screenshot 2023-11-03 at 08 13 32

Also just came across the CRAN MacOS Builder. Still not really clear on what it is, but might be a way to get rid of some of the NOTES about biocViews and BiocPkgTools:
https://mac.r-project.org/macbuilder/submit.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CRAN Issue related to the CRAN server
Projects
None yet
Development

No branches or pull requests

1 participant