Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimal Control extension #247

Merged
merged 284 commits into from Dec 22, 2023
Merged

Optimal Control extension #247

merged 284 commits into from Dec 22, 2023

Conversation

lenasal
Copy link
Collaborator

@lenasal lenasal commented Sep 11, 2023

optimal control methods for ALN, WC, Hopf and FHN models
example notebooks (deterministic and noisy)
tests

lenasal and others added 30 commits July 28, 2022 15:58
- updated test cases according to changed default parameters
- applied automated code formatting to all changed files and test-files
# Conflicts:
#	neurolib/optimal_control/cost_functions.py
#	neurolib/optimal_control/oc_fhn/oc_fhn.py
#	neurolib/optimal_control/oc_fhn/oc_fhn_jit.py
#	neurolib/optimal_control/tests/test_fhn_noisy.py
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@caglorithm caglorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust README, otherwise LGTM. I would say let's merge and fix bugs as they appear.

@lenasal
Copy link
Collaborator Author

lenasal commented Dec 15, 2023

thanks for reviewing, please have a look at the changes

README.md Outdated Show resolved Hide resolved
@caglorithm caglorithm merged commit 762456a into neurolib-dev:master Dec 22, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants