-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimal control of Wong Wang model #257
base: master
Are you sure you want to change the base?
Conversation
lenasal
commented
Jan 16, 2024
- minor changes in model implementation for consistency with other models
- full implementation of OC for WW model
- test of OC for WW model
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #257 +/- ##
==========================================
- Coverage 91.14% 90.80% -0.33%
==========================================
Files 65 67 +2
Lines 5189 5240 +51
==========================================
+ Hits 4729 4758 +29
- Misses 460 482 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
for consistency
This became a pretty big change and is not out of scope for the PR. Just checking: Did you test the changed models to see if this breaks anything? |
I didn't test beyond the automatic tests. But since all notebooks and test files are checked, this should be the same as running them manually? |